[Release][Core] Increase version to v2.6.1 #1519
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
MSNev
commented
Mar 30, 2021
MSNev
commented
- [BUG] v2.6.0 is not re-hydrating the automatic session id correctly for each request [BUG] v2.6.0 is not re-hydrating the automatic session id correctly for each request #1518
- [BUG] v2.6.0 is not re-hydrating the automatic session id correctly for each request #1518
MSNev
requested review from
trask,
ramthi,
lzchen,
xiao-lix,
hectorhdzg,
heyams and
kryalama
MSNev
commented
Mar 30, 2021
| } else if (session.id) { | ||
| // If we don't have an id then considered it to be expired | ||
| // Only assign the values if everything looks good | ||
| } else if (tokens[0]) { |
There was a problem hiding this comment.
This is where the bug was introduced - as the caller of this function only calls _initializeAutomaticSession() if (!session.id) -- so this was always false and subsequently got removed from the code.
There was a problem hiding this comment.
Will add additional tests after pushing out the hotfix.
MSNev
commented
Mar 30, 2021
| ### Changelog | ||
|
|
||
| - #1518 P1 - [BUG] v2.6.0 is not re-hydrating the automatic session id correctly for each request | ||
| - #1512 Expose the getCookieMgr() on the snippet proxy and analytics web instances |
There was a problem hiding this comment.
This change is already checked in, and as it's additive the risk or blasting this change out is low / non-existence (famous last words).
kryalama
approved these changes
Mar 30, 2021
xiao-lix
approved these changes
Mar 30, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.