Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove exposing global instances of __extends() and __assign() and update sideEffects usage (by removing globals) #1523

Merged
merged 1 commit into from
Apr 15, 2021
Merged

Remove exposing global instances of __extends() and __assign() and update sideEffects usage (by removing globals) #1523

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions .gitignore
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -249,6 +249,7 @@ temp
# Rush files
common/temp/**
package-deps.json
package-lock.json

# test output
aicore.tests.js*
Expand Down
6 changes: 4 additions & 2 deletions AISKU/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -46,6 +46,7 @@
"grunt-ts": "^6.0.0-beta.22",
"grunt-tslint": "^5.0.2",
"globby": "^11.0.0",
"magic-string": "^0.25.7",
"@rollup/plugin-commonjs": "^15.1.0",
"@rollup/plugin-node-resolve": "^9.0.0",
"@rollup/plugin-replace": "^2.3.3",
Expand All @@ -56,11 +57,12 @@
"source-map-loader": "^0.2.3",
"tslint": "^5.19.0",
"tslint-config-prettier": "^1.18.0",
"typescript": "2.5.3"
"typescript": "2.5.3",
"tslib": "^1.13.0"
},
"dependencies": {
"@microsoft/dynamicproto-js": "^1.1.1",
"@microsoft/applicationinsights-shims" : "1.0.3",
"@microsoft/applicationinsights-shims" : "2.0.0",
"@microsoft/applicationinsights-analytics-js": "2.6.1",
"@microsoft/applicationinsights-channel-js": "2.6.1",
"@microsoft/applicationinsights-common": "2.6.1",
Expand Down
2 changes: 0 additions & 2 deletions AISKU/src/applicationinsights-web.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,3 @@
import '@microsoft/applicationinsights-shims';

export {
IApplicationInsights,
Snippet,
Expand Down
3 changes: 2 additions & 1 deletion AISKU/tsconfig.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,8 +9,9 @@
"alwaysStrict": true,
"suppressImplicitAnyIndexErrors": true,
"allowSyntheticDefaultImports": true,
"importHelpers": false,
"importHelpers": true,
"noEmitHelpers": true,
"skipLibCheck": true,
kryalama marked this conversation as resolved.
Show resolved Hide resolved
"forceConsistentCasingInFileNames": true,
"declaration": true,
"declarationDir": "AISKU/types",
Expand Down
1 change: 0 additions & 1 deletion AISKULight/index.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,7 +1,6 @@
// Copyright (c) Microsoft Corporation. All rights reserved.
// Licensed under the MIT License.

import '@microsoft/applicationinsights-shims';
import {
IConfiguration,
AppInsightsCore,
Expand Down
4 changes: 3 additions & 1 deletion AISKULight/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -25,19 +25,21 @@
"grunt-run": "^0.8.1",
"grunt-ts": "^6.0.0-beta.22",
"globby": "^11.0.0",
"magic-string": "^0.25.7",
"@rollup/plugin-commonjs": "^15.1.0",
"@rollup/plugin-node-resolve": "^9.0.0",
"@rollup/plugin-replace": "^2.3.3",
"rollup-plugin-cleanup": "3.2.1",
"rollup": "^2.32.0",
"source-map-loader": "^0.2.3",
"typescript": "2.5.3",
"tslib": "^1.13.0",
"tslint": "^5.19.0",
"tslint-config-prettier": "^1.18.0"
},
"dependencies": {
"@microsoft/dynamicproto-js": "^1.1.1",
"@microsoft/applicationinsights-shims" : "1.0.3",
"@microsoft/applicationinsights-shims" : "2.0.0",
"@microsoft/applicationinsights-common": "2.6.1",
"@microsoft/applicationinsights-channel-js": "2.6.1",
"@microsoft/applicationinsights-core-js": "2.6.1"
Expand Down
3 changes: 2 additions & 1 deletion AISKULight/tsconfig.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,8 +9,9 @@
"alwaysStrict": true,
"suppressImplicitAnyIndexErrors": true,
"allowSyntheticDefaultImports": true,
"importHelpers": false,
"importHelpers": true,
"noEmitHelpers": true,
"skipLibCheck": true,
"forceConsistentCasingInFileNames": true,
"declaration": true,
"declarationDir": "AISKULight/types",
Expand Down
4 changes: 3 additions & 1 deletion channels/applicationinsights-channel-js/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -29,20 +29,22 @@
"grunt-run": "^0.8.1",
"grunt-ts": "^6.0.0-beta.22",
"globby": "^11.0.0",
"magic-string": "^0.25.7",
"@rollup/plugin-commonjs": "^15.1.0",
"@rollup/plugin-node-resolve": "^9.0.0",
"@rollup/plugin-replace": "^2.3.3",
"rollup-plugin-cleanup": "3.2.1",
"rollup": "^2.32.0",
"typescript": "2.5.3",
"tslib": "^1.13.0",
"tslint": "^5.19.0",
"tslint-config-prettier": "^1.18.0",
"qunit": "^2.9.1",
"sinon": "^7.3.1"
},
"dependencies": {
"@microsoft/dynamicproto-js": "^1.1.1",
"@microsoft/applicationinsights-shims" : "1.0.3",
"@microsoft/applicationinsights-shims" : "2.0.0",
"@microsoft/applicationinsights-core-js": "2.6.1",
"@microsoft/applicationinsights-common": "2.6.1"
},
Expand Down
2 changes: 0 additions & 2 deletions channels/applicationinsights-channel-js/src/applicationinsights-channel-js.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,3 +1 @@
import '@microsoft/applicationinsights-shims';

export { Sender } from "./Sender";
3 changes: 2 additions & 1 deletion channels/applicationinsights-channel-js/tsconfig.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,8 +10,9 @@
"suppressImplicitAnyIndexErrors": true,
"allowSyntheticDefaultImports": true,
"forceConsistentCasingInFileNames": true,
"importHelpers": false,
"importHelpers": true,
"noEmitHelpers": true,
"skipLibCheck": true,
"declaration": true,
"declarationDir": "channels/applicationinsights-channel-js/types",
"outDir": "dist-esm",
Expand Down
6 changes: 5 additions & 1 deletion common/Tests/Framework/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -41,10 +41,14 @@
"@rollup/plugin-replace": "^2.3.3",
"rollup": "^2.32.0",
"typescript": "2.5.3",
"tslib": "^1.13.0",
"qunit": "^2.9.1",
"sinon": "^7.3.1"
"sinon": "^7.3.1",
"globby": "^11.0.0",
"magic-string": "^0.25.7"
},
"dependencies": {
"@microsoft/applicationinsights-shims" : "2.0.0",
"@microsoft/dynamicproto-js": "^1.1.1"
}
}
3 changes: 3 additions & 0 deletions common/Tests/Framework/rollup.config.js
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,5 @@
import nodeResolve from "@rollup/plugin-node-resolve";
import { updateDistEsmFiles } from "../../../tools/updateDistEsm/updateDistEsm";

const version = require("./package.json").version;
const outputName = "ai-test-framework";
Expand Down Expand Up @@ -29,6 +30,8 @@ const nodeUmdRollupConfigFactory = () => {
return nodeRollupConfig;
}

updateDistEsmFiles({}, banner);

export default [
nodeUmdRollupConfigFactory(),
];
3 changes: 2 additions & 1 deletion common/Tests/Framework/tsconfig.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,8 +7,9 @@
"moduleResolution": "node",
"target": "es5",
"forceConsistentCasingInFileNames": true,
"importHelpers": false,
"importHelpers": true,
"noEmitHelpers": true,
"skipLibCheck": true,
"alwaysStrict": true,
"declaration": true,
"outDir": "dist-esm/",
Expand Down
Loading