[Typings] Update the TypeScript typings to identify the readonly properties/fields and dynamic values of the snippet #1546 #1548
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MSNev
reviewed
Apr 23, 2021
| @@ -40,7 +40,7 @@ export interface ITelemetryContext { | |||
| /** | |||
| * The object describing a user tracked by this object. | |||
| */ | |||
| user: IUserContext; | |||
| readonly user: IUserContext; | |||
There was a problem hiding this comment.
There will be a LOT more than just these.
We need to go over all of the API surface and allocate the correct settings.
eg. All of the TelemetryContext objects should be readonly,
MSNev
changed the title
MSNev
approved these changes
Apr 28, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Address #1546