Script error: Browser exception message not providing information type and method #363 #1562
Conversation
| @@ -0,0 +1,24 @@ | |||
| import { ITypeValidator } from './ITypeValidator'; | |||
There was a problem hiding this comment.
Effectively copied from AISKU to the shared framework -- I didn't refactor the AISKU tests to use the framework as part of this PR as this is already larger than I'd like.
| @@ -7,7 +7,7 @@ | |||
| "summary": "Run all tests for all packages", | |||
| "description": "Runs tests for all projects", | |||
| "safeForSimultaneousRushProcesses": false, | |||
| "enableParallelism": true, | |||
| "enableParallelism": false, | |||
There was a problem hiding this comment.
As part of changing the tests to run via http:// instead of file:// we can only have 1 http server running on the test port.
| <link rel="stylesheet" href="../../../../common//Tests//External/qunit-1.23.1.css"> | ||
| <script src="../../../../common/Tests/Selenium/ExceptionHelper.js"></script> | ||
| <!-- <script src="http://sinonjs.org/releases/sinon-2.3.8.js" crossorigin="anonymous"></script> --> | ||
| <script src="../../../../common/Tests/External/sinon-7.3.1.js"></script> --> |
There was a problem hiding this comment.
Use local copies rather than relying on external site.
| connect: { | ||
| server: { | ||
| options: { | ||
| port: 9001, |
There was a problem hiding this comment.
Using port 9001 (mainly so it doesn't clash with internal project extensions -- so I can run multiple project tests at the same time)
| @@ -4,7 +4,7 @@ | |||
| import { Envelope as AIEnvelope } from '../../Interfaces/Contracts/Generated/Envelope'; | |||
| import { Base } from '../../Interfaces/Contracts/Generated/Base'; | |||
| import { IEnvelope } from '../../Interfaces/Telemetry/IEnvelope'; | |||
| import { DataSanitizer } from './DataSanitizer'; | |||
| import { dataSanitizeString } from './DataSanitizer'; | |||
There was a problem hiding this comment.
Refactored the DataSanitize static class for minification improvements.
MSNev
force-pushed
the
MSNev/UpdateErrorReporting
branch
from
ab216a7
to
30203dc
Compare
| exception = e; | ||
| this._ai.trackException({ exception: autoTelemetry }); | ||
| } catch (e) { | ||
| console.log(e); |
There was a problem hiding this comment.
nit: is this console.log intentional?
| const exceptionDetailsConverted = _ExceptionDetails.CreateFromInterface(this.logger, exceptionDetailsInterface); | ||
| Assert.deepEqual(exceptionDetails, exceptionDetailsConverted); | ||
| } catch (e) { | ||
| console.log(e.stack); |
There was a problem hiding this comment.
nit: is this intentional?
No description provided.