Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ai_user cookie should use userCookiePostfix for user cookie storage #1587

Merged
merged 6 commits into from
Jun 22, 2021

Conversation

xiao-lix
Copy link
Contributor

@xiao-lix xiao-lix requested a review from MSNev June 17, 2021 19:49
@xiao-lix xiao-lix added this to the 2.x.x (Next Release) milestone Jun 17, 2021
MSNev
MSNev previously requested changes Jun 17, 2021
Copy link
Collaborator

@MSNev MSNev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We need to add a config for this to avoid breaking anyone.

@xiao-lix xiao-lix changed the title ai_user cookie should use name prefix for cookie storage configured ai_user cookie should use userCookiePostfix for user cookie storage Jun 18, 2021
@xiao-lix xiao-lix dismissed MSNev’s stale review June 22, 2021 01:06

Added the requested changes in update commit

@xiao-lix xiao-lix merged commit 01b9820 into master Jun 22, 2021
@MSNev MSNev deleted the lxiao/user-cookie-name branch August 4, 2021 19:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants