Apply the eslint fixes (from Component Governance Checks) #1596
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
MSNev
commented
Jun 29, 2021
MSNev
commented
- Update ts-plugin dependency version
MSNev
requested review from
ramthi,
lzchen,
xiao-lix,
hectorhdzg,
kryalama and
Karlie-777
MSNev
commented
Jun 29, 2021
| IChannelControls, hasWindow, hasDocument, isReactNative, doPerf, IDiagnosticLogger, INotificationManager, objForEachKey, proxyAssign, | ||
| import { | ||
| IConfiguration, AppInsightsCore, IAppInsightsCore, LoggingSeverity, _InternalMessageId, ITelemetryItem, ICustomProperties, | ||
| IChannelControls, hasWindow, hasDocument, isReactNative, doPerf, IDiagnosticLogger, INotificationManager, objForEachKey, proxyAssign, |
There was a problem hiding this comment.
These are just mixed whitespace issues (had spaces and tabs)
MSNev
commented
Jun 29, 2021
| @@ -81,7 +81,7 @@ export class LogEntry { | |||
| ms = "0" + ms; | |||
| } | |||
|
|
|||
| ms = ms.replace(/(.)(\d{3})+$/g, '$1.$2s') | |||
| ms = ms.replace(/(.)(\d{3}){1}$/g, '$1.$2s') | |||
There was a problem hiding this comment.
The regex changes are security related and a little more complicated and the changes are 2 fold
- Unnecessary escaping (additional \ when not needed), this could allow someone to "fiddle" with the resulting regex (in memory) to change it's behavior
- When using * and +, depending on the input string unconstrained matching can cause the regex to use excessive memory, cpu or just fail.
MSNev
force-pushed
the
MSNev/UpdateDependencies
branch
5 times, most recently
from
ba948f8
to
2f6184b
Compare
- Update minimum dependency versions to address installation
MSNev
force-pushed
the
MSNev/UpdateDependencies
branch
from
2f6184b
to
095d6f1
Compare
MSNev
assigned ramthi, xiao-lix, hectorhdzg, kryalama and Karlie-777 and unassigned ramthi, xiao-lix, hectorhdzg, kryalama and Karlie-777
hectorhdzg
approved these changes
Jul 6, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.