-
Notifications
You must be signed in to change notification settings - Fork 237
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Stale Issue / PR GitHub Action #1617
Conversation
MSNev
commented
Jul 22, 2021
- Starting with high values because we have not had this before
- Initial values should be 300 days => stale and 30 days => close
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Added a couple of suggestion for text change.
- Starting with high values because we have not had this before - Initial values should be 300 days => stale and 30 days => close
days-before-close: 30 | ||
stale-issue-label: 'stale' | ||
stale-pr-label: 'stale' | ||
close-issue-label: 'closed' |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't think closed issues/prs need a label.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I added this so that we can track (at least initially) the set of issues / PR's that get closed automatically vs all of the others that we have and will close manually (which won't have these labels). According to the documentation the action will also remove this if it gets re-opened.
So eventually (once we are in a much better sate) I agree this will not be needed but as we currently have 117 open (most of which I expect will eventually get closed by this) and 622 Closed I want an easier way to identify these auto-closed items.
stale-issue-label: 'stale' | ||
stale-pr-label: 'stale' | ||
close-issue-label: 'closed' | ||
close-pr-label: 'closed' |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I would add a message instead on automatic close. See OpenTelemetry
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We already have a message for when it goes stale, which when closed would be the last message. So I don't think that it's necessary...
I think that by using the label it's a bit more concise and also more searchable without getting false positive matches.