[BUG] customProperties parameter missing from trackException function #1647 #1651
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MSNev
requested review from
ramthi,
xiao-lix,
hectorhdzg,
kryalama and
Karlie-777
xiao-lix
reviewed
Aug 31, 2021
| exception = e; | ||
| this._ai.trackException({ exception: autoTelemetry }, { custom: "custom value" }); | ||
| } catch (e) { | ||
| console.log(e); |
There was a problem hiding this comment.
nit: Are the console logs on purpose? But I guess it's fine to have in tests.
There was a problem hiding this comment.
Assert.ok(false) fails the test correct? and the stack is displayed as the error message. What is the purpose of console.log?
There was a problem hiding this comment.
Correct, console.log is for easier debugging the failure in a browser.
xiao-lix
approved these changes
Aug 31, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.