-
Notifications
You must be signed in to change notification settings - Fork 240
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Some requests are returning a CORB error for responses containing text content type #1683 #1658
Conversation
MSNev
commented
Sep 4, 2021
- Use fetch with keepalive support during unload by default (Main CORB fix)
- Fix fetch usage to stop tracking the track call
- Minification and minor performance improvements
@@ -45,7 +45,7 @@ export class AISKUSizeCheck extends TestClass { | |||
return; | |||
} else { | |||
return response.text().then(text => { | |||
let size = Math.ceil(pako.deflate(text).length/1024); | |||
let size = Math.ceil((pako.deflate(text).length/1024) * 100) / 100.0; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just updating test so it displays how close we are to the max value -- to 2 decimal places
@@ -0,0 +1,30 @@ | |||
import { DistributedTracingModes } from '@microsoft/applicationinsights-common'; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Run same base e2e tests using fetch, instead of XHR
} | ||
}); | ||
} | ||
/* |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
All minification improvements -- removing the internal class so the referenced names can be minified.
…t content type #1653 - Use fetch with keepalive support during unload by default (Main CORB fix) - Fix fetch usage to stop tracking the track call - Minification and minor performance improvements
d94cf21
to
5630378
Compare
| onunloadDisableBeacon | boolean | false | Default false. when tab is closed, the SDK will send all remaining telemetry using the [Beacon API](https://www.w3.org/TR/beacon) | | ||
| onunloadDisableFetch | boolean | false | If fetch keepalive is supported do not use it for sending events during unload, it may still fallback to fetch() without keepalive | |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nit: can we use onUnloadDisableFetch instead
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is consistent with the onunloadDisableBeacon