Some requests are returning a CORB error for responses containing text content type #1683 #1658
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
MSNev
commented
Sep 4, 2021
MSNev
commented
- Use fetch with keepalive support during unload by default (Main CORB fix)
- Fix fetch usage to stop tracking the track call
- Minification and minor performance improvements
MSNev
requested review from
ramthi,
xiao-lix,
hectorhdzg,
kryalama and
Karlie-777
MSNev
commented
Sep 4, 2021
| @@ -45,7 +45,7 @@ export class AISKUSizeCheck extends TestClass { | |||
| return; | |||
| } else { | |||
| return response.text().then(text => { | |||
| let size = Math.ceil(pako.deflate(text).length/1024); | |||
| let size = Math.ceil((pako.deflate(text).length/1024) * 100) / 100.0; | |||
There was a problem hiding this comment.
Just updating test so it displays how close we are to the max value -- to 2 decimal places
MSNev
commented
Sep 4, 2021
| @@ -0,0 +1,30 @@ | |||
| import { DistributedTracingModes } from '@microsoft/applicationinsights-common'; | |||
There was a problem hiding this comment.
Run same base e2e tests using fetch, instead of XHR
MSNev
commented
Sep 4, 2021
| } | ||
| }); | ||
| } | ||
| /* |
There was a problem hiding this comment.
All minification improvements -- removing the internal class so the referenced names can be minified.
…t content type #1653 - Use fetch with keepalive support during unload by default (Main CORB fix) - Fix fetch usage to stop tracking the track call - Minification and minor performance improvements
MSNev
force-pushed
the
MSNev/CorsBIssue
branch
from
d94cf21
to
5630378
Compare
kryalama
approved these changes
Sep 7, 2021
| | onunloadDisableBeacon | boolean | false | Default false. when tab is closed, the SDK will send all remaining telemetry using the [Beacon API](https://www.w3.org/TR/beacon) | | ||
| | onunloadDisableFetch | boolean | false | If fetch keepalive is supported do not use it for sending events during unload, it may still fallback to fetch() without keepalive | |
There was a problem hiding this comment.
nit: can we use onUnloadDisableFetch instead
There was a problem hiding this comment.
This is consistent with the onunloadDisableBeacon
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.