Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

expose internal log poller #1674

Merged
merged 10 commits into from
Oct 1, 2021
Merged

expose internal log poller #1674

merged 10 commits into from
Oct 1, 2021

Conversation

kryalama
Copy link
Contributor

Address #1667

@olee
Copy link

olee commented Sep 18, 2021

I don't think it's necessary to expose the internal timer but instead just a method to stop the internal polling.
That would also allow the framework to properly know whether the timer is running or not which would not work when exposing the timer handle and just letting users cancel it.

AISKU/src/Initialization.ts Outdated Show resolved Hide resolved
Copy link
Collaborator

@MSNev MSNev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lets not expose the internal interval timer value

AISKU/src/Initialization.ts Outdated Show resolved Hide resolved
@kryalama kryalama requested a review from MSNev September 30, 2021 22:36
AISKU/src/Initialization.ts Outdated Show resolved Hide resolved
@kryalama kryalama requested a review from MSNev September 30, 2021 23:25
@MSNev MSNev added this to the 2.x.x (Future Release) milestone Sep 30, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants