Add support to optionally configure the events used for detecting and handling when page unload and flushing occurs #1683 #1684
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… handling when page unload and flushing occurs #1683
MSNev
requested review from
ramthi,
lzchen,
xiao-lix,
hectorhdzg,
kryalama and
Karlie-777
kryalama
approved these changes
Oct 6, 2021
Comment on lines
+71
to
+74
| if (!added && excluded.length > 0) { | ||
| // Failed to add any listeners and we excluded some, so just attempt to add the excluded events | ||
| added = addEventListeners(excluded, listener); | ||
| } |
There was a problem hiding this comment.
just curios, why are we doing this?
There was a problem hiding this comment.
We attempt to "listen" to any and all unload / show events, however, if the config provides a list of events that would "exclude" events (based on the current runtime environment (browser)) then we would end up listening to nothing.
So the "exclude" events is treated as a best effort.
- If at least one event can be hooked (excluding the requested), then we are happy and continue
- If no event can be hooked (because they all got excluded or the environment doesn't support then), then we try and hook all of the original events (including the requested excluded set)
MSNev
added
waiting - CDN deployment
released - NPM
and removed
waiting - CDN deployment
labels
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.