fix readme traceID generate method #1687
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MSNev
reviewed
Oct 7, 2021
README.md
Outdated
| @@ -419,7 +419,7 @@ Breaking changes in the SDK V2 version: | |||
| - ES3 (IE8) compatibility, while running in IE8 or lower versions of the browser is not an officially supported scenario we are working to maintain ES3 level compatibility to ensure that the SDK will not cause any unexpected failures due to Javascript parsing error. See [ES3/IE8 Compatibility](#es3ie8-compatibility) below for further information. | |||
| - Telemetry envelope has field name and structure changes due to data schema updates. | |||
| - Moved `context.operation` to `context.telemetryTrace`. Some fields were also changed (`operation.id` --> `telemetryTrace.traceID`) | |||
| - If you want to maunally refresh the current pageview id (e.g. in SPA apps) this can be done with `appInsights.context.telemetryTrace.traceID = Util.newId()` | |||
| - If you want to maunally refresh the current pageview id (e.g. in SPA apps) this can be done with `appInsights.context.telemetryTrace.traceID = Util.generateW3CId()` | |||
There was a problem hiding this comment.
Drop the Util. prefix as there is now a generateW3Cid() function as per the recommendations in the Tree Shaking Support and Enhancements section of the readme
MSNev
approved these changes
Oct 7, 2021
MSNev
added
waiting - CDN deployment
released - NPM
and removed
waiting - CDN deployment
labels
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
appInsights.context.telemetryTrace.traceID = Util.newId()should beappInsights.context.telemetryTrace.traceID = Util.generateW3CId()