Karlie/refactor ai SKU test and add PerfTest #1707
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Code refactor, should be completed before Nov 8th,2021
|
MSNev
reviewed
Nov 8, 2021
MSNev
approved these changes
Nov 8, 2021
| @@ -0,0 +1,7 @@ | |||
| import { AISKUPerf } from "./AISKUPerf.Tests"; | |||
| //Do not remove this import, it will be used in browser. | |||
| import { Snippet } from "../../../src/Initialization"; | |||
There was a problem hiding this comment.
Is this still required, I'm not seeing any references anymore
There was a problem hiding this comment.
When removing this import (this import wouldn't be used in the code), it will have Failed to load resource: the server responded with a status of 404 (Not Found) when processing with Returning module - @microsoft/ai-test-framework.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Refactor AISKU test structure and add AISKU perfTest.
This PR include 2.7.1 to the version loop