[Chrome-ext] Update nightly download link and add version check #1720
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MSNev
requested review from
xiao-lix,
hectorhdzg,
KevBrown-MSFT,
kryalama and
Karlie-777
MSNev
force-pushed
the
MSNev/ChromeDebugExtension
branch
from
a77c6a8
to
f0d6d95
Compare
MSNev
commented
Nov 20, 2021
|
|
||
| export const TelemetryViewerPopup = (): React.ReactElement => { | ||
| const [appPhase, setAppPhase] = React.useState<AppPhase>("Startup"); | ||
| const [session, setSession] = React.useState<Session | undefined>(undefined); | ||
| const [configurationType, setConfigurationType] = React.useState<ConfigurationType>(undefined); | ||
| let newAvailableVersion: string; | ||
| // let newVersionDownload: string; |
There was a problem hiding this comment.
Was originally planning on having some sort of dynamic update -- but that is more work so this is really a placeholder
MSNev
commented
Nov 20, 2021
| if ((count % 2) == 0) { | ||
| document.title = orgTitle; | ||
| } else { | ||
| document.title = orgTitle + " *** v" + encodeURIComponent(newAvailableVersion) + " Available ***" |
There was a problem hiding this comment.
Very simple "flashing" title to show the new available version number (really just a different version -- assumes that we only move forward)
MSNev
commented
Nov 20, 2021
| @@ -462,7 +462,7 @@ const setPackageJsonRelease = () => { | |||
| } | |||
|
|
|||
| if (theFilename.indexOf("/package.json") !== -1) { | |||
| let srcFolder = theFilename.replace("/package.json", "/**/*.ts"); | |||
| let srcFolder = theFilename.replace("/package.json", "/**/*.ts", "/**/*.tsx", "/**/*.html"); | |||
There was a problem hiding this comment.
Just update our build level version replacement logic to support updating the build versions in *.tsx and *.html files -- this is used for manually updating versions via npm run setVersion -- 2.x.x and the nightly builds
kryalama
approved these changes
Nov 22, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.