Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

deprecate ikey #1817

Merged
merged 7 commits into from
May 9, 2022
Merged

deprecate ikey #1817

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
be35d2f
deprecat ikey
Karlie-777 Apr 22, 2022
7cdd0a4
resolve comments
Karlie-777 May 9, 2022
4bbd1df
remove unused import
Karlie-777 May 9, 2022
9a4215a
change error message
Karlie-777 May 9, 2022
948f74b
Merge branch 'master' into karlie/deprecatedikey
Karlie-777 May 9, 2022
6a279ac
update
Karlie-777 May 9, 2022
013907d
shorten error messgae
Karlie-777 May 9, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 8 additions & 0 deletions AISKU/src/Initialization.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -189,6 +189,14 @@ export class Initialization implements IApplicationInsights {
_core = new AppInsightsCore();
_self.core = _core;


if (!config.connectionString) {
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We talked about also adding a config to disable this (for large customers who don't want to be annoyed by this message)

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I will create another PR to add the config! Thanks Nev!

_throwInternal(_core.logger,
eLoggingSeverity.CRITICAL,
_eInternalMessageId.InstrumentationKeyDeprecation,
"Instrumentation key support will end soon, see aka.ms/IkeyMigrate");
}

_self.snippet = snippet;
_self.config = config;
_getSKUDefaults();
Expand Down
7 changes: 5 additions & 2 deletions shared/AppInsightsCore/src/JavaScriptSDK.Enums/LoggingEnums.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -105,7 +105,8 @@ export const enum _eInternalMessageId {
InvalidContentBlob = 102,
TrackPageActionEventFailed = 103,
FailedAddingCustomDefinedRequestContext = 104,
InMemoryStorageBufferFull = 105
InMemoryStorageBufferFull = 105,
InstrumentationKeyDeprecation = 106
}

/**
Expand Down Expand Up @@ -196,6 +197,8 @@ export const _InternalMessageId = createEnumStyle<typeof _eInternalMessageId>({
InvalidContentBlob: _eInternalMessageId.InvalidContentBlob,
TrackPageActionEventFailed: _eInternalMessageId.TrackPageActionEventFailed,
FailedAddingCustomDefinedRequestContext: _eInternalMessageId.FailedAddingCustomDefinedRequestContext,
InMemoryStorageBufferFull: _eInternalMessageId.InMemoryStorageBufferFull
InMemoryStorageBufferFull: _eInternalMessageId.InMemoryStorageBufferFull,
InstrumentationKeyDeprecation: _eInternalMessageId.InstrumentationKeyDeprecation

});
export type _InternalMessageId = number | _eInternalMessageId;