Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Extracting HOC tracked component class base for re-use #1829

Merged
merged 4 commits into from
May 5, 2022

Conversation

bittola
Copy link
Contributor

@bittola bittola commented May 4, 2022

While withAITracking function is working in most of the cases, it's not useful in a scenario when a content of the wrapped component is not physically located under the component's DOM tree.
An example of that is Modal component from Microsoft Fluent UI framework but there are many other similar cases too.
Therefore, a developer may sometimes need to create a custom version of the HOC function, which for example, as in the case of the Modal component would wrap a content instead of the component itself, however still have the same tracking functionality as the app insights library HOC function.

The change here extract the HOC class so it can be re-used and customized by consumers of the library

@ghost
Copy link

ghost commented May 4, 2022

CLA assistant check
All CLA requirements met.

@MSNev MSNev added this to the 2.8.3 milestone May 4, 2022
@MSNev MSNev added the react label May 4, 2022
@MSNev MSNev merged commit 4391b21 into microsoft:master May 5, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants