Task 7496325: Add Distributed tracing population for the properties for the core #1846 #1847
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
MSNev
commented
May 27, 2022
MSNev
commented
- Single Page Application Page View Tracking Single Page Application Page View Tracking #176
- Run-time Telemetry initializers for Ajax requests Run-time Telemetry initializers for Ajax requests #198
- How to modify traceflag in traceparent header? How to modify traceflag in traceparent header? #1776
Karlie-777
approved these changes
May 31, 2022
ramthi
reviewed
May 31, 2022
| import { ITraceParent } from "./Interfaces/ITraceParent"; | ||
| import { ITraceParent } from "../JavaScriptSDK.Interfaces/ITraceParent"; | ||
| import { generateW3CId } from "./CoreUtils"; | ||
| import { findMetaTag, findNamedServerTiming, getDocument, getPerformance } from "./EnvUtils"; |
There was a problem hiding this comment.
There is code scanning alert for unused import!
There was a problem hiding this comment.
Will check and fix those
ramthi
reviewed
May 31, 2022
| let navPerf = perf.getEntriesByType("navigation") || []; | ||
| traceParent = parseTraceParent(_getTraceParentValue((navPerf.length > 0 ? navPerf[0] : {} as any).serverTiming).description); | ||
| } | ||
| traceParent = parseTraceParent(findNamedServerTiming(name)) |
There was a problem hiding this comment.
I didn't know this. What is the use case when the traceparent would be sent in service timing?
There was a problem hiding this comment.
This is an "optional" way to pass values as the server-timing are the only request headers that JS has access to -- we would use this if the auto injection can't add any "meta" tag for some reason.
MSNev
commented
May 31, 2022
| }); | ||
|
|
||
| _self.context = new TelemetryContext(core, _extensionConfig); | ||
| _breezeChannel = getExtensionByName(extensions, BreezeChannelIdentifier); | ||
| _self.context.appId = () => _breezeChannel ? _breezeChannel["_appId"] : null; | ||
| _previousTraceCtx = core.getTraceCtx(false); |
There was a problem hiding this comment.
Edge case initialization change: Should populate any previously set values (on the previous trace) against the "new" telemetryTrace instance (if not supplied) -- probably won't be here.
MSNev
force-pushed
the
MSNev/DistributedTrace
branch
from
2fdbf45
to
6ea3d15
Compare
Also address CodeQL issues
MSNev
force-pushed
the
MSNev/DistributedTrace
branch
from
6ea3d15
to
74e9bcd
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.