Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cherry-Picking beta fix so merging master -> beta stops breaking nightly beta release #1881

Merged
merged 1 commit into from
Aug 16, 2022
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 4 additions & 1 deletion AISKU/Tests/Unit/src/AISKUSize.Tests.ts
Original file line number Diff line number Diff line change
Expand Up @@ -9,9 +9,12 @@ export class AISKUSizeCheck extends AITestClass {
private readonly MAX_RAW_DEFLATE_SIZE = 46;
private readonly MAX_BUNDLE_DEFLATE_SIZE = 47;
private readonly rawFilePath = "../dist/applicationinsights-web.min.js";
private readonly prodFilePath = "../browser/ai.2.min.js";
// Automatically updated by version scripts
private readonly currentVer = "2.8.5";
private readonly prodFilePath = `../browser/ai.${this.currentVer[0]}.min.js`;

public testInitialize() {

}

public testFinishedCleanup(): void {
Expand Down
14 changes: 8 additions & 6 deletions AISKU/Tests/Unit/src/CdnPackaging.tests.ts
Original file line number Diff line number Diff line change
Expand Up @@ -12,6 +12,8 @@ const enum CdnFormat {
}

export class CdnPackagingChecks extends AITestClass {
// Automatically updated by version scripts
private readonly currentVer = "2.8.5";

public testInitialize() {
}
Expand Down Expand Up @@ -46,15 +48,15 @@ export class CdnPackagingChecks extends AITestClass {
}

private checkFullPackaging(): void {
this._checkPackaging("../browser/ai.2.js", CdnFormat.Umd);
this._checkPackaging("../browser/ai.2.gbl.js", CdnFormat.Gbl);
this._checkPackaging("../browser/ai.2.cjs.js", CdnFormat.CommonJs);
this._checkPackaging(`../browser/ai.${this.currentVer[0]}.js`, CdnFormat.Umd);
this._checkPackaging(`../browser/ai.${this.currentVer[0]}.gbl.js`, CdnFormat.Gbl);
this._checkPackaging(`../browser/ai.${this.currentVer[0]}.cjs.js`, CdnFormat.CommonJs);
}

private addMinifiedPackaging(): void {
this._checkPackaging("../browser/ai.2.min.js", CdnFormat.Umd);
this._checkPackaging("../browser/ai.2.gbl.min.js", CdnFormat.Gbl);
this._checkPackaging("../browser/ai.2.cjs.min.js", CdnFormat.CommonJs);
this._checkPackaging(`../browser/ai.${this.currentVer[0]}.min.js`, CdnFormat.Umd);
this._checkPackaging(`../browser/ai.${this.currentVer[0]}.gbl.min.js`, CdnFormat.Gbl);
this._checkPackaging(`../browser/ai.${this.currentVer[0]}.cjs.min.js`, CdnFormat.CommonJs);
}

private _validateExpectedExports(theExports: any) {
Expand Down