V3 Beta - Remove Legacy code and ES3 support from V2 SDK #1888
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
MSNev
commented
Aug 18, 2022
MSNev
commented
- Remove ES3 polyfills (Breaking change from V2)
- Remove Deprecated (v1) API compatibility layer (Breaking change from V2)
- Remove unused namespace globals (Breaking change from V2)
- Document breaking changes
MSNev
requested review from
ramthi,
lzchen,
hectorhdzg,
JacksonWeber and
Karlie-777
MSNev
commented
Aug 18, 2022
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
MSNev
force-pushed
the
MSNev/BetaRemoveLegacy
branch
from
c8f9761
to
fd5bac5
Compare
…n process Task 13988566: [Beta] Remove Legacy code from V2 SDK - Remove Exported namespace globals
MSNev
force-pushed
the
MSNev/BetaRemoveLegacy
branch
from
fd5bac5
to
ffbf5a4
Compare
Karlie-777
approved these changes
Aug 24, 2022
Karlie-777
reviewed
Aug 24, 2022
| @@ -57,7 +54,7 @@ export interface Snippet { | |||
| } | |||
|
|
|||
| export interface IApplicationInsights extends IAppInsights, IDependenciesPlugin, IPropertiesPlugin { | |||
| appInsights: ApplicationInsights; | |||
| appInsights: AnalyticsPlugin; | |||
There was a problem hiding this comment.
I am just curious, ApplicationInsights includes deprecated instance, so we switch to analyticsplugin directly here?
There was a problem hiding this comment.
For this one I renamed the exported object from "ApplicationInsights" to "AnalyticsPlugin" a few releases ago and as part of this (for backward compatibility) it also exported the "AnalyticsPlugin" as "ApplicationInsights" (so 2 names referencing the same class).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.