Update QUnit and tests #1964
Update QUnit and tests #1964
Conversation
MSNev
commented
Dec 16, 2022
MSNev
commented
- Update minify script to use PC newline for imports and header banners
| @@ -5,13 +5,13 @@ | |||
| <meta charset="utf-8"> | |||
| <meta http-equiv="Cache-control" content="no-Cache" /> | |||
| <title>Tests for Application Insights JavaScript AISKU</title> | |||
| <link rel="stylesheet" href="https://code.jquery.com/qunit/qunit-1.23.1.css"> | |||
| <link rel="stylesheet" href="../../../common/Tests/External/qunit-2.9.3.css"> | |||
There was a problem hiding this comment.
Most of the changes in this PR are from my investigations to "fix" the GitHub test runs.
This is updating to the current version of GitHub and requireJs -- which did break the CDN Packaging tests because of how they now load and run modules.
| @@ -133,38 +137,131 @@ export class CdnPackagingChecks extends AITestClass { | |||
| // Remove any "exports" | |||
| exports = {}; | |||
|
|
|||
| // Used to simulate loading a cjs module | |||
| let cjsModule = this["_cjsModule"] = {}; | |||
| // Used to simulate globals without overriding them | |||
There was a problem hiding this comment.
Fixing the tests that where broken by the qunit and requirejs updates. But this also provided the ability to more fully tests the different initialization options
| "// !!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!\n" + | ||
| "// Note: DON'T Export these const from the package as we are still targeting ES3 this will export a mutable variables that someone could change!!!\n" + | ||
| "// !!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!\n\n"; | ||
| "// Copyright (c) Microsoft Corporation. All rights reserved.\r\n" + |
There was a problem hiding this comment.
This fixes the issues where once building you end up with files that "look" like they have changed.
It turns out that the issue was related to the different new line (\r\n) that the files are defaulted to and that this script was only creating the files with "\n"
MSNev
force-pushed
the
MSNev/UpdateComponents
branch
5 times, most recently
from
e9770ae
to
7f8f8c1
Compare
MSNev
force-pushed
the
MSNev/UpdateComponents
branch
from
7f8f8c1
to
7e67551
Compare
