[Beta][Task]15982357: Dynamic config for Properties extension #1972
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MSNev
reviewed
Jan 25, 2023
| @@ -116,6 +105,20 @@ export class _SessionManager { | |||
| const session = _self.automaticSession; | |||
| _setStorage(session.id, session.acquisitionDate, session.renewalDate); | |||
| }; | |||
|
|
|||
| function _storageNamePrefix(): string { | |||
There was a problem hiding this comment.
I'm not a fan of this pattern, but I understand why :-(
I'm currently working on fixing the referencing issue, so I might undo these functions with my PR (after you have submitted this one)
There was a problem hiding this comment.
Thanks Nev! I added TODO in the code!
MSNev
approved these changes
Jan 25, 2023
MSNev
added a commit
that referenced
this pull request
Jan 27, 2023
…nsion #1972 - Add ability to tag Dynamic Config properties as referenced to support updating extensionConfig in-place with a new object instance - Add IUnloadHookContainer to allow passing extension level unload hook container to sub-components
MSNev
added a commit
that referenced
this pull request
Jan 27, 2023
…nsion #1972 - Add ability to tag Dynamic Config properties as referenced to support updating extensionConfig in-place with a new object instance - Add IUnloadHookContainer to allow passing extension level unload hook container to sub-components
MSNev
added a commit
that referenced
this pull request
Jan 27, 2023
…nsion #1972 - Add ability to tag Dynamic Config properties as referenced to support updating extensionConfig in-place with a new object instance - Add IUnloadHookContainer to allow passing extension level unload hook container to sub-components
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.