[AI][Task]16961420: fix throttleMgr incorrectly fires based on the number of days past #1981
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MSNev
reviewed
Feb 1, 2023
| if (_isSpecificDaysGiven) { | ||
| dayCheck = arrIndexOf(interval.daysOfMonth, curDate.getUTCDate()); | ||
| } else { | ||
| let dayInternal = _checkInterval(interval.dayInterval, date.getUTCDate(), curDate.getUTCDate()); |
There was a problem hiding this comment.
getUTCDate() returns the date of the month, so it's not really the "interval", for example if the previous date was the 31st and today is the 2nd with an interval of 2 should cause it to fire.
I think you need to calculate the number of days between the 2 dates (if there is a last date)
Something like.
let diffDays = Math.floor(curDate.getTime() - date.getTime() / 86400000);
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
MSNev
approved these changes
Feb 1, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#1979