[Main] Fix extension / channel not being readonly #2018
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
MSNev
commented
Mar 14, 2023
MSNev
commented
- Bug fixes for getPlugin() not searching the TeeChannel
- Minification improcements
MSNev
requested review from
ramthi,
hectorhdzg,
JacksonWeber,
Karlie-777 and
siyuniu-ms
MSNev
commented
Mar 14, 2023
| _autoCapture = false; | ||
|
|
||
| // Define _self.config | ||
| objDefineProp(self, "config", { |
There was a problem hiding this comment.
This was actually adding a config property to window...
Note: the self is missing the _ prefix and even if it had that it's outside of the closure that defines _self...
So just removing as it's not used (or valid) to populate window.config
MSNev
commented
Mar 14, 2023
| enumerable: true, | ||
| configurable: true, | ||
| get: function() { | ||
| objDefine(_self, "context", { |
There was a problem hiding this comment.
Using objDefine() as the defaults for enumerable and configurable are true and it avoids adding these uncompressible names
MSNev
commented
Mar 14, 2023
| [STR_EXTENSIONS]: [], | ||
| [STR_CHANNELS]: [], | ||
| [STR_EXTENSION_CONFIG]: {}, | ||
| [STR_EXTENSIONS]: { rdOnly: true, ref: true, v: [] }, |
There was a problem hiding this comment.
This is one of the main parts that makes the extensions and channels readonly enforced.
MSNev
commented
Mar 14, 2023
- Bug fixes for getPlugin() not searching the TeeChannel - Minification improcements
MSNev
force-pushed
the
MSNev/ReleaseFixes
branch
from
2b70493
to
026fa16
Compare
MSNev
commented
Mar 14, 2023
| * @param pageName | ||
| * @returns {} | ||
| */ | ||
| function startPageVisitTimer(pageName: string, pageUrl: string) { |
There was a problem hiding this comment.
Just removing and collapsing a function that is only used once
Karlie-777
approved these changes
Mar 14, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.