[Main] Add support to tag objects to force or block dynamic conversion #2020
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MSNev
requested review from
ramthi,
hectorhdzg,
JacksonWeber,
Karlie-777 and
siyuniu-ms
siyuniu-ms
reviewed
Mar 17, 2023
MSNev
commented
Mar 17, 2023
| @@ -62,7 +62,7 @@ function _createDynamicHandler<T extends IConfiguration>(logger: IDiagnosticLogg | |||
| } | |||
|
|
|||
| function _setValue<C, V>(target: C, name: string, value: V) { | |||
| return _setDynamicProperty(theState, target, name, value); | |||
| return _setDynamicProperty(theState, target, name, value)[name]; | |||
There was a problem hiding this comment.
I changed the _setDynamicProperty() to return then target rather than the target[name] as that was indirectly causing the objects to be referenced and converted to be dynamic (if they where not already).
This caused an issue when "setting" the default values (which didn't use the returned value) and also indirectly caused everything to become dynamic during initialization whether referenced or not.
MSNev
force-pushed
the
MSNev/ReleaseFixes
branch
from
0f9be85
to
d4b0c36
Compare
MSNev
changed the title
Karlie-777
approved these changes
Mar 17, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.