[Master] Fix examples, Throttle tests and export dependency types from Sku #2026
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MSNev
requested review from
ramthi,
hectorhdzg,
JacksonWeber,
Karlie-777 and
siyuniu-ms
MSNev
commented
Mar 29, 2023
| let dayOfMonth = date.getDate(); | ||
| if (dayOfMonth > (daysInMonth[month - 1] + (month === 2 ? (isLeapYear(year - 1) ? 1 : 0 ) : 0 ))) { | ||
| date.setDate(daysInMonth[month - 1] + (month === 2 ? (isLeapYear(year - 1) ? 1 : 0 ) : 0 )); | ||
| } | ||
| date.setUTCMonth(month-1); |
There was a problem hiding this comment.
These tests started failing today because Feb 29, 30, 31 don't exist 😄 . So just simple test fixes to set to the last day of the previous month as the same issue would occur for Oct, Dec, May, Jul 31st.
Karlie-777
approved these changes
Mar 29, 2023
MSNev
force-pushed
the
MSNev/MasterFixes
branch
from
06538fd
to
5de855a
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.