[Master] Add local storage-based implementation #1419 #2037
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
peitschie
commented
Apr 6, 2023
peitschie
commented
Apr 6, 2023
MSNev
reviewed
Apr 6, 2023
peitschie
force-pushed
the
simple-local-storage
branch
from
d790830
to
cefddab
Compare
|
I've pushed a full rewrite of this PR @MSNev. Once you're happy with the prod code, I'll add some tests proving the configuration options all behave nicely 🙂 I can appreciate major releases are many moving parts, so am happy to keep tweaking this until it fits nicely into your release plans! |
MSNev
reviewed
Apr 6, 2023
peitschie
force-pushed
the
simple-local-storage
branch
3 times, most recently
from
952a894
to
d92af76
Compare
…osoft#1419 This can be used like: ``` const appInsights = new ApplicationInsights({ config: { enableSessionStorageBuffer: true, bufferOverride: { getItem: (logger, key) => localStorage.getItem(key), setItem: (logger, key, value) => localStorage.setItem(key, value), } } }); ```
peitschie
force-pushed
the
simple-local-storage
branch
from
d92af76
to
d2b9c67
Compare
|
I've added tests exercising the new config paths now. |
MSNev
approved these changes
Apr 7, 2023
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
| _self._buffer = (_self._senderConfig.enableSessionStorageBuffer() && utlCanUseSessionStorage()) | ||
| ? new SessionStorageSendBuffer(diagLog, _self._senderConfig) : new ArraySendBuffer(diagLog, _self._senderConfig); | ||
| const useSessionStorage = _self._senderConfig.enableSessionStorageBuffer() && | ||
| (_self._senderConfig.bufferOverride() || utlCanUseSessionStorage()) |
Check notice
Code scanning / CodeQL
Semicolon insertion
MSNev
changed the title
MSNev
added a commit
that referenced
this pull request
Apr 11, 2023
#2037) This can be used like: ``` const appInsights = new ApplicationInsights({ config: { enableSessionStorageBuffer: true, bufferOverride: { getItem: (logger, key) => localStorage.getItem(key), setItem: (logger, key, value) => localStorage.setItem(key, value), } } }); ``` Co-authored-by: Nev <54870357+MSNev@users.noreply.github.com>
MSNev
added a commit
that referenced
this pull request
Apr 12, 2023
* [BUG] The documentation for enableDebug is incorrect, it should reference enableDebugExceptions #2014 (#2022) * [BUG] SDK LOAD Failure reporting not working #2027 (#2038) * Add a simple interface to enable custom buffer storage solutions #1419 (#2037) This can be used like: ``` const appInsights = new ApplicationInsights({ config: { enableSessionStorageBuffer: true, bufferOverride: { getItem: (logger, key) => localStorage.getItem(key), setItem: (logger, key, value) => localStorage.setItem(key, value), } } }); ``` Co-authored-by: Nev <54870357+MSNev@users.noreply.github.com> * [Master] Add readme documentation for IStorageBuffer (#2045) * [Release] Increase version to 2.8.12 (#2046) --------- Co-authored-by: Philip Peitsch <philip.peitsch@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I'm aiming for the smallest diff with this to allow local storage.
This can be used like:
UPDATED
I wasn't sure if I should expose this on config just yet (e.g.,
enableLocalStorageBuffer). Ideally this eventually becomes a pluggable component, so that a hypotheticalIndexedDbor completely custom storage mechanism can be inserted trivially. I thought about adding a simple factory method toIConfig, but theISendBufferinterface is not available to that package currently.Open to any feedback on this, including rejection if it's not taking this mechanism in a direction you're comfortable with.
Longer term, I'm starting to poke at how to nicely make the
ISendBufferasync to allow more flexible storage mechanisms to be built, but enabling local storage seemed a very useful first step regardless.