Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Main] Fix Perf Tests #2051

Merged
merged 2 commits into from
Apr 21, 2023
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion AISKU/Tests/Perf/src/AISKUPerf.Tests.ts
Original file line number Diff line number Diff line change
@@ -1,5 +1,6 @@
import { AITestClass, Assert } from "@microsoft/ai-test-framework";
import {AppInsightsInitPerfTestClass} from "./AISKUPerf";
import { AppInsightsInitPerfTestClass } from "./AISKUPerf";
import { utlRemoveSessionStorage } from "@microsoft/applicationinsights-common";

function isNullOrUndefined(value: any): boolean {
return value === undefined || value === null;
Expand Down
2 changes: 0 additions & 2 deletions AISKU/Tests/Perf/src/aiskuperftests.ts
Original file line number Diff line number Diff line change
@@ -1,6 +1,4 @@
import { AISKUPerf } from "./AISKUPerf.Tests";
//Do not remove this import, it will be used in browser.
import { Snippet } from "../../../src/Initialization";

export function runTests() {
new AISKUPerf().registerTests();
Expand Down
2 changes: 1 addition & 1 deletion AISKU/Tests/PerfTests.html
Original file line number Diff line number Diff line change
Expand Up @@ -28,7 +28,7 @@

loadFetchModule(modules, "whatwg-fetch");
loadCommonModules(modules, function() {
var testModule = modules.add("Tests/Perf/src/aiskuperftests", "./Perf/dist/aiskuperftests.tests.js")
var testModule = modules.add("aiskuperftests", "./Perf/dist/es5/aiskuperftests.tests.js")
testModule.run = function (tests) {
console && console.log("Starting tests");
QUnit.start();
Expand Down
3 changes: 2 additions & 1 deletion AISKU/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -61,7 +61,8 @@
"selenium-server-standalone-jar": "^3.141.5",
"serve-static": "^1.13.2",
"typescript": "^4.9.3",
"tslib": "^2.0.0"
"tslib": "^2.0.0",
"puppeteer": "19.2.0"
},
"peerDependencies": {
"tslib": "*"
Expand Down
2 changes: 1 addition & 1 deletion common/Tests/Framework/src/AITestClass.ts
Original file line number Diff line number Diff line change
Expand Up @@ -432,7 +432,7 @@ export class AITestClass {
self._assertHooksRemoved();
}

AITestClass.currentTestClass._testCompleted(failed);
AITestClass.currentTestClass && AITestClass.currentTestClass._testCompleted(failed);
done();
}

Expand Down
Loading