[Master] Add ability to disable the pollInternalLogs via config and change to stop using setInterval #2055 #2056
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MSNev
force-pushed
the
MSNev/IntervalTimer
branch
3 times, most recently
from
6b70fe0
to
9e6dea6
Compare
siyuniu-ms
approved these changes
Apr 21, 2023
siyuniu-ms
reviewed
Apr 21, 2023
| clearInterval(intervalHandle); | ||
| intervalHandle = null; | ||
| if (queueTimer) { | ||
| clearInterval(queueTimer); |
There was a problem hiding this comment.
Do we need to change this to clearTimeout here?
There was a problem hiding this comment.
Oh, nice catch, its actually the other way around this should stay as clearInterval but line 68 should be setInterval
There was a problem hiding this comment.
Correction, as this is the PageViewManager yes this should be clearTimeout.
Github needs a double thumbs up 😄
…hange to stop using setInterval #2055
MSNev
force-pushed
the
MSNev/IntervalTimer
branch
from
9e6dea6
to
9768345
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.