[main] fix startTime timestamp #2183
Conversation
| } else { | ||
| // calculate the start time manually | ||
| let duration = ((customProperties || pageView.properties || {}).duration || 0); | ||
| pageView.startTime = new Date(new Date().getTime() - duration); |
There was a problem hiding this comment.
This still needs to be done of ALL other cases, otherwise the reported "time" will be wrong.
There was a problem hiding this comment.
Otherwise the Portal will show the wrong "startTime"
| pageView.startTime = new Date(perf.timeOrigin + loadEventStart); | ||
| } else { | ||
| // calculate the start time manually | ||
| let duration = ((properties || pageView.properties || {}).duration || 0); |
There was a problem hiding this comment.
Looking at all of the "usages" of the sendPageViewInternal, it looks like (once we remove this from here), that we should do this duration update in the AngularPlugin.ts Line 602 (before the _pageTracking calls the _self.sendPageViewInternal so that the "time" is still shifted back by the duration otherwise the Portal will show the wrong "startTime"
There was a problem hiding this comment.
Maybe?? (testing required)
We can just keep something here like
if (isNullOrUndefined(pageView.startTime)) {
// calculate the start time manually
let duration = ((properties || pageView.properties || {}).duration || 0);
if (duration) {
pageView.startTime = new Date(new Date().getTime() - duration);
}
}
So that if the previous code (like the line 602 above) doesn't specify any startTime then we keep "using" this default, this should also work for the subsequent page views, even with your code below for the if (!firstPageViewSent){
|
manual test time result: second page view triggered around 3 seconds after: |
only modify the startTime for first page view telemetry