[main] offlineListener preparation

[siyuniu-ms]

No description provided.

[MSNev]

As above, the list should be an array and an edge case that has to be handled is that someone "could" call this rm function multiple times, so the first time will remove the entry (if present) and subsequent times will do nothing.

On way to do this is to use a temporary variable and then when rm is called you just reassign the rm function on that variable (that you return) to a function that does nothing.

[siyuniu-ms]

function addListener(callback: OfflineCallback) {
        listenerList.push(callback);
        const rm = (callback: OfflineCallback) => {
            let removed = false;
            return () => {
                if (!removed) {
                    const index = listenerList.indexOf(callback);
                    if (index !== -1) {
                        // Remove the callback from the list
                        listenerList.splice(index, 1);
                        removed = true; // Mark it as removed
                    }
                }
            };
        };
        return rm;
}

does this works?

[siyuniu-ms]

seems like it does not work, vs is complaining the type error

[MSNev]

Actually the this is not required.

[MSNev]

Do we have any tests for this as any tests should be failing.

[siyuniu-ms]

we do not have any test on this new code yet, maybe we could merge this into karlie's offline branch instead of main branch?

[siyuniu-ms]

the current test is failing because of dep, I will rerun the rush update

[MSNev]

Lets just push into main as we are now not planning any more releases from this branch until this feature set is complete.

If we need to release a version 3.0.5 we will create a branch for that release.

[MSNev]

Lets wait until we do the patch release before committing this, so that we don't have to branch.

[MSNev]

ready to go