[main] disable sdk load error send #1672 #2207
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MSNev
reviewed
Dec 6, 2023
README.md
Outdated
| @@ -85,6 +85,7 @@ The current version of the snippet is version 7, the version is identified by th | |||
| // name: "appInsights", // Global SDK Instance name defaults to "appInsights" when not supplied | |||
| // ld: 0, // Defines the load delay (in ms) before attempting to load the sdk. -1 = block page load and add to head. (default) = 0ms load after timeout, | |||
| // useXhr: 1, // Use XHR instead of fetch to report failures (if available), | |||
| // disableSdkLoadError: true, // Prevent the SDK from reporting load failure, | |||
There was a problem hiding this comment.
Can we make this smaller, as the snippet needs to be able to be as small as possible.
something like dle, dlf, dler etc -- as long as the documentation has a good description this should be as small as possible (but not just d for example) as most consumers wont' use this as we don't want to have losts of additional code thats rarely used.
MSNev
approved these changes
Dec 7, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
related to #1672