Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Main][BUG] Beacon sender reports error for success when diagnostics are enabled #2204 #2212

Merged
merged 1 commit into from
Dec 7, 2023
Merged

[Main][BUG] Beacon sender reports error for success when diagnostics are enabled #2204 #2212

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion channels/applicationinsights-channel-js/src/Sender.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -708,8 +708,9 @@ export class Sender extends BaseTelemetryPlugin implements IChannelControls {
//TODO: handle other status codes
if (status === 200 && payload) {
_self._onSuccess(payload, payload.length);
} else {
response && _self._onError(payload, response);
}
response && _self._onError(payload, response);
}

function _doSend(sendInterface: IXHROverride, payload: string[], isAsync: boolean, markAsSent: boolean = true): void | IPromise<boolean> {
Expand Down
Loading