[Main][Task]26451789: Add Offline Support #2241
Conversation
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
| _maxBatchInterval = storageConfig.maxSentBatchInterval; | ||
| _maxBatchSize = storageConfig.maxBatchsize; | ||
| } | ||
| _urlCfg = urlConfig; |
There was a problem hiding this comment.
Add todo: this will overwrite any "previous" if the endpoint is changed as you construct a "new" one. Which means all of the previous stuff will either get lost or left behind in memory -- because it will never be cleaned up on teardown.
There was a problem hiding this comment.
created task 26681188 for this
|
|
||
| public _appId: string; //TODO: set id | ||
|
|
||
| constructor(endpointUrl?: string) { |
There was a problem hiding this comment.
Add a TODO: to remove the passing (and internal usages) of the endpointURL, as your already always creating without an endpoint anyway.
If there is no other endpoint (the URL) lets just not send anything
There was a problem hiding this comment.
Actually, lets add a TODO to remove this class completely so we can delegate the "sending" to the real channels via a new "sendbatch" (or something like that) on IOfflineSupport, that way we don't need to worry about all of the transports etc)
There was a problem hiding this comment.
Endpoint is removed, and if no url is provided, doOncomplete will be called with status code 400 and will throw internal as well.
created Task 26681160 for this to add more tests
TODO: add security doc to let users know that data would be stored