Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[main] [snippet update] add functions to set configs of snippet #2245

Merged
merged 10 commits into from
Jan 23, 2024
Merged

[main] [snippet update] add functions to set configs of snippet #2245

merged 10 commits into from
Jan 23, 2024

Conversation

siyuniu-ms
Copy link
Contributor

No description provided.

@siyuniu-ms siyuniu-ms marked this pull request as draft January 18, 2024 20:25
@siyuniu-ms
Copy link
Contributor Author

siyuniu-ms commented Jan 19, 2024 •
edited
Loading

Maybe with the helper func, we could remove const webSnippetCs = "##replaceConnStringSnippet##"? Currently, the only difference between webSnippet and webSnippetCs is:
webSnippet ends with connectionString: "InstrumentationKey=INSTRUMENTATION_KEY
webSnippetcs ends with connectionString: "YOUR_CONNECTION_STRING"\r\n
btw, maybe webSnippet should end with instrumentationKey: "YOUR_INSTRUMENTATION_KEY, this maybe a mistake when I wrote the rush json months before

@siyuniu-ms siyuniu-ms marked this pull request as ready for review January 19, 2024 01:36
@siyuniu-ms siyuniu-ms requested a review from MSNev January 23, 2024 08:58
@siyuniu-ms siyuniu-ms merged commit ee6e2f8 into main Jan 23, 2024
9 checks passed
@siyuniu-ms siyuniu-ms deleted the siyu/snippetFunc branch January 23, 2024 23:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MSNev MSNev MSNev approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@siyuniu-ms @MSNev