-
Notifications
You must be signed in to change notification settings - Fork 237
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[BUG] Excessive memory usage for SPA where unload hooks keep accumulating #2311 #2312
Merged
+606
−283
Merged
Changes from all commits
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,13 @@ | ||
import { Assert } from "@microsoft/ai-test-framework"; | ||
import { _testHookMaxUnloadHooksCb } from "@microsoft/applicationinsights-core-js"; | ||
import { dumpObj } from "@nevware21/ts-utils"; | ||
|
||
export class GlobalTestHooks { | ||
|
||
public registerTests() { | ||
// Set a global maximum | ||
_testHookMaxUnloadHooksCb(20, (state: string, hooks: Array<any>) => { | ||
Assert.ok(false, "Max unload hooks exceeded [" + hooks.length + "] - " + state + " - " + dumpObj(hooks)); | ||
}); | ||
} | ||
} |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,13 @@ | ||
import { Assert } from "@microsoft/ai-test-framework"; | ||
import { _testHookMaxUnloadHooksCb } from "@microsoft/applicationinsights-core-js"; | ||
import { dumpObj } from "@nevware21/ts-utils"; | ||
|
||
export class GlobalTestHooks { | ||
|
||
public registerTests() { | ||
// Set a global maximum | ||
_testHookMaxUnloadHooksCb(20, (state: string, hooks: Array<any>) => { | ||
Assert.ok(false, "Max unload hooks exceeded [" + hooks.length + "] - " + state + " - " + dumpObj(hooks)); | ||
}); | ||
} | ||
} |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
13 changes: 13 additions & 0 deletions
13
channels/1ds-post-js/test/Unit/src/GlobalTestHooks.Test.ts
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,13 @@ | ||
import { _testHookMaxUnloadHooksCb } from "@microsoft/1ds-core-js"; | ||
import { Assert } from "@microsoft/ai-test-framework"; | ||
import { dumpObj } from "@nevware21/ts-utils"; | ||
|
||
export class GlobalTestHooks { | ||
|
||
public registerTests() { | ||
// Set a global maximum | ||
_testHookMaxUnloadHooksCb(20, (state: string, hooks: Array<any>) => { | ||
Assert.ok(false, "Max unload hooks exceeded [" + hooks.length + "] - " + state + " - " + dumpObj(hooks)); | ||
}); | ||
} | ||
} |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
13 changes: 13 additions & 0 deletions
13
channels/applicationinsights-channel-js/Tests/Unit/src/GlobalTestHooks.Test.ts
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,13 @@ | ||
import { Assert } from "@microsoft/ai-test-framework"; | ||
import { _testHookMaxUnloadHooksCb } from "@microsoft/applicationinsights-core-js"; | ||
import { dumpObj } from "@nevware21/ts-utils"; | ||
|
||
export class GlobalTestHooks { | ||
|
||
public registerTests() { | ||
// Set a global maximum | ||
_testHookMaxUnloadHooksCb(20, (state: string, hooks: Array<any>) => { | ||
Assert.ok(false, "Max unload hooks exceeded [" + hooks.length + "] - " + state + " - " + dumpObj(hooks)); | ||
}); | ||
} | ||
} |
2 changes: 2 additions & 0 deletions
2
channels/applicationinsights-channel-js/Tests/Unit/src/aichannel.tests.ts
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,7 +1,9 @@ | ||
import { SenderTests } from "./Sender.tests"; | ||
import { SampleTests } from "./Sample.tests"; | ||
import { GlobalTestHooks } from "./GlobalTestHooks.Test"; | ||
|
||
export function runTests() { | ||
new GlobalTestHooks().registerTests(); | ||
new SenderTests().registerTests(); | ||
new SampleTests().registerTests(); | ||
} |
13 changes: 13 additions & 0 deletions
13
channels/offline-channel-js/Tests/Unit/src/GlobalTestHooks.Test.ts
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,13 @@ | ||
import { Assert } from "@microsoft/ai-test-framework"; | ||
import { _testHookMaxUnloadHooksCb } from "@microsoft/applicationinsights-core-js"; | ||
import { dumpObj } from "@nevware21/ts-utils"; | ||
|
||
export class GlobalTestHooks { | ||
|
||
public registerTests() { | ||
// Set a global maximum | ||
_testHookMaxUnloadHooksCb(20, (state: string, hooks: Array<any>) => { | ||
Assert.ok(false, "Max unload hooks exceeded [" + hooks.length + "] - " + state + " - " + dumpObj(hooks)); | ||
}); | ||
} | ||
} |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
13 changes: 13 additions & 0 deletions
13
channels/tee-channel-js/Tests/Unit/src/GlobalTestHooks.Test.ts
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,13 @@ | ||
import { Assert } from "@microsoft/ai-test-framework"; | ||
import { _testHookMaxUnloadHooksCb } from "@microsoft/applicationinsights-core-js"; | ||
import { dumpObj } from "@nevware21/ts-utils"; | ||
|
||
export class GlobalTestHooks { | ||
|
||
public registerTests() { | ||
// Set a global maximum | ||
_testHookMaxUnloadHooksCb(20, (state: string, hooks: Array<any>) => { | ||
Assert.ok(false, "Max unload hooks exceeded [" + hooks.length + "] - " + state + " - " + dumpObj(hooks)); | ||
}); | ||
} | ||
} |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,5 +1,7 @@ | ||
import { TeeChannelCoreTests } from "./TeeChannelCore.Tests"; | ||
import { GlobalTestHooks } from "./GlobalTestHooks.Test"; | ||
|
||
export function runTests() { | ||
new GlobalTestHooks().registerTests(); | ||
new TeeChannelCoreTests().registerTests(); | ||
} |
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is using a "hack" of our current test infrastructure to "set" some global configuration that will affect "ALL" tests that follow the initialization. (which is why this was added as the "first" item of every tests bundle.
Of note, is that IF any test also changes / sets / calls the test hook it will "replace" and invalidate this setting (as this is currently a single value, not a list of callbacks)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
They also needed to be created / added here as the "common" test infrastructure does not have access to the main "Application Insights" code to be able to add code specific "hooks"