Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

common: add tests for canIncludeCorrelationHeader #899

Merged
merged 2 commits into from
Jun 3, 2019
Merged

common: add tests for canIncludeCorrelationHeader #899

merged 2 commits into from
Jun 3, 2019

Conversation

markwolff
Copy link
Contributor

@markwolff markwolff commented May 28, 2019 •
edited
Loading

  • Add tests for canIncludeCorrelationHeader.
  • minor: Replace Array.some logic

@markwolff
Copy link
Contributor Author

@LeopoldLerch

@LeopoldLerch
Copy link
Contributor

I might be wrong, but Array.prototype.forEach is also not supported in IE < 9

@markwolff
Copy link
Contributor Author

Yep you are correct. Moving forward, it might not be feasible to plan for <IE8 support at all.

@LeopoldLerch
Copy link
Contributor

LeopoldLerch commented May 29, 2019 via email

@markwolff markwolff merged commit 16f5f95 into master Jun 3, 2019
@markwolff markwolff deleted the markwolff/add-correlationheader-tests branch June 3, 2019 19:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hectorhdzg hectorhdzg hectorhdzg approved these changes

@ramthi ramthi Awaiting requested review from ramthi

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@markwolff @LeopoldLerch @hectorhdzg