analytics: move to last priority of default plugins #928
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hectorhdzg
reviewed
Jun 10, 2019
| @@ -30,7 +30,7 @@ export class ApplicationInsights implements IAppInsights, ITelemetryPlugin, IApp | |||
| public static Version = "2.0.1"; // Not currently used anywhere | |||
| public initialize: (config: IConfiguration, core: IAppInsightsCore, extensions: IPlugin[]) => void; | |||
| public identifier: string = "ApplicationInsightsAnalytics"; // do not change name or priority | |||
| public priority: number = 160;// take from reserved priority range 100- 200 | |||
| public priority: number = 199;// take from reserved priority range 100- 200 | |||
hectorhdzg
reviewed
Jun 10, 2019
hectorhdzg
approved these changes
Jun 25, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Custom telemetry intializers are run in
processTelemetryin the analytics plugin. It needs to be made as the last priority among the default plugins so that all other telemetry information from other plugins is available to custom telemetry initializers.Also removes minified entry point from
core