add feature - track header data for ajax & fetch requests' response and put to part c properties bag #946
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
markwolff
reviewed
Jun 25, 2019
vNext/extensions/applicationinsights-dependencies-js/src/ajax.ts
Outdated
Show resolved
Hide resolved
vNext/extensions/applicationinsights-dependencies-js/src/ajax.ts
Outdated
Show resolved
Hide resolved
markwolff
reviewed
Jun 27, 2019
vNext/extensions/applicationinsights-dependencies-js/src/ajax.ts
Outdated
Show resolved
Hide resolved
markwolff
reviewed
Jul 2, 2019
markwolff
reviewed
Jul 2, 2019
vNext/shared/AppInsightsCore/src/JavaScriptSDK.Enums/LoggingEnums.ts
Outdated
Show resolved
Hide resolved
markwolff
reviewed
Jul 2, 2019
markwolff
reviewed
Jul 3, 2019
markwolff
reviewed
Jul 22, 2019
markwolff
reviewed
Jul 22, 2019
vNext/extensions/applicationinsights-dependencies-js/src/ajax.ts
Outdated
Show resolved
Hide resolved
markwolff
reviewed
Jul 22, 2019
vNext/extensions/applicationinsights-dependencies-js/src/ajax.ts
Outdated
Show resolved
Hide resolved
vNext/extensions/applicationinsights-dependencies-js/src/ajax.ts
Outdated
Show resolved
Hide resolved
markwolff
approved these changes
Jul 23, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adding feature of tracking response headers data of ajax and fetch requests in dependency plugin. This feature is off by default. It can be turned on by setting the config flag "enableHeaderTracking: true" when initializing the ApplicationInsights instances. All data are stored in customer properties bag.
Example of Fetch request result in Azure Portal:
Example of Ajax request result in Azure Portal:
Related issue: #736