Skip to content

Commit

Permalink
Build changes: Add an Automatic Module Name to Runtime Attach library (
Browse files Browse the repository at this point in the history
…#2503)

* Build changes needed to add an Automatic Module Name to Runtime Attach (#1)

Build changes needed to add an Automatic Module Name so this library can be imported into modular java projects.

* I'll build with 17 since that's what we're using for the modular app that needs this.

* going back to 8 since the groovy warnings don't matter.

* changelog updates from PR review.

* Update agent/runtime-attach/build.gradle.kts

Co-authored-by: Trask Stalnaker <trask.stalnaker@gmail.com>

* changelog updates to give new name.

* ran ./gradlew :spotlessApply as per pipeline failure message

Co-authored-by: Trask Stalnaker <trask.stalnaker@gmail.com>
  • Loading branch information
KrogerWalt and trask authored Sep 12, 2022
1 parent 95c15d8 commit a27bff0
Show file tree
Hide file tree
Showing 2 changed files with 15 additions and 0 deletions.
12 changes: 12 additions & 0 deletions CHANGELOG.md
Original file line number Diff line number Diff line change
@@ -1,5 +1,17 @@
# CHANGELOG

# Version 3.4.0-BETA.2

Migration notes:

* If you were using Automatic naming before, you will need to update your module-info.java file.
Change ```requires applicationinsights.runtime.attach;``` to
```requires com.microsoft.applicationinsights.runtime.attach;``` and everything should work.

Enhancements:

* Automatic module name enttry added to Runtime Attach library Jar to support Modular Java.

# Version 3.4.0-BETA

Migration notes:
Expand Down
3 changes: 3 additions & 0 deletions agent/runtime-attach/build.gradle.kts
Original file line number Diff line number Diff line change
Expand Up @@ -20,5 +20,8 @@ tasks {
from({
agent.singleFile
})
manifest {
attributes("Automatic-Module-Name" to "com.microsoft.applicationinsights.attach")
}
}
}

0 comments on commit a27bff0

Please sign in to comment.