Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add internal-reflection instrumentation #1912

Merged
merged 2 commits into from
Oct 13, 2021
Merged

Add internal-reflection instrumentation #1912

merged 2 commits into from
Oct 13, 2021

Conversation

trask
Copy link
Member

@trask trask commented Oct 12, 2021 •
edited
Loading

Hopefully this should resolve reported issue:

Unsatisfied dependency expressed through bean property '__opentelemetryContext$java$lang$Runnable'

attaching snapshot for testing: applicationinsights-agent-3.2.1-BETA-SNAPSHOT.jar.zip

@heyams
Copy link
Contributor

heyams commented Oct 12, 2021

do we need to track it as a new statsbeat feature?

@trask
Copy link
Member Author

trask commented Oct 12, 2021

do we need to track it as a new statsbeat feature?

no, the internal instrumentations cannot be disabled, and do not produce any telemetry themselves

@trask trask merged commit e7b7aa6 into main Oct 13, 2021
@trask trask deleted the add-internal-reflection-instrumentation branch October 13, 2021 21:03
@kryalama kryalama added this to the 3.2.1-BETA milestone Oct 21, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@heyams heyams heyams approved these changes

@kryalama kryalama Awaiting requested review from kryalama

@xiao-lix xiao-lix Awaiting requested review from xiao-lix

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
3.2.1 GA
Development

Successfully merging this pull request may close these issues.
3 participants
@trask @heyams @kryalama