Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix jackson initialization #1984

Merged
merged 1 commit into from
Nov 29, 2021
Merged

Fix jackson initialization #1984

merged 1 commit into from
Nov 29, 2021

Conversation

trask
Copy link
Member

@trask trask commented Nov 28, 2021

No description provided.

@trask trask marked this pull request as ready for review November 29, 2021 19:17
@heyams
Copy link
Contributor

heyams commented Nov 29, 2021

fix makes sense. just curious to know any customer issues regarding this? when it's not found, json is corrupted?

@trask
Copy link
Member Author

trask commented Nov 29, 2021

just curious to know any customer issues regarding this?

this was not customer reported, I ran into it myself when testing a command-line app that just emitted telemetry via 2.x SDK (and was very confused about it for a while).

when it's not found, json is corrupted?

exports fail because it can't find json mapping for OffsetDateTime which our model uses for timestamps

@trask trask merged commit 0713811 into main Nov 29, 2021
@trask trask deleted the fix-jackson-initialization branch November 29, 2021 23:22
@william-kirovski-kr
Copy link

william-kirovski-kr commented Dec 7, 2021

I am seeing this issue in my logs. It is repeating over and over. I am temporarily suppressing this message, as it seems you have a fix in place for it. I am using the latest 3.2.3.jar

2021-12-06 21:51:05.447-05:00 WARN c.m.a.a.i.telemetry.TelemetryChannel - Sending telemetry to the ingestion service (telemetry will be stored to disk on failure and retried later):: Error encoding telemetry items: Java 8 date/time type java.time.OffsetDateTime not supported by default: add Module "com.fasterxml.jackson.datatype:jackson-datatype-jsr310" to enable handling (through reference chain: com.microsoft.applicationinsights.agent.internal.exporter.models.TelemetryItem["time"]) (future warnings will be aggregated and logged once every 5 minutes

com.fasterxml.jackson.databind.exc.InvalidDefinitionException: Java 8 date/time type java.time.OffsetDateTime not supported by default: add Module "com.fasterxml.jackson.datatype:jackson-datatype-jsr310" to enable handling (through reference chain: com.microsoft.applicationinsights.agent.internal.exporter.models.TelemetryItem["time"])

Do you know the impact, and when this fix will make it into a release?

@trask
Copy link
Member Author

trask commented Dec 8, 2021

hi @william-kirovski-kr! we are planning to a release with this included by end of this week.

I believe the impact is that you will not see any telemetry in the Portal if you are seeing this error.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants