Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support capturing http headers #2036

Merged
merged 2 commits into from
Jan 10, 2022
Merged

Support capturing http headers #2036

merged 2 commits into from
Jan 10, 2022

Conversation

trask
Copy link
Member

@trask trask commented Jan 8, 2022

Resolves #1693

@trask trask marked this pull request as ready for review January 10, 2022 17:11
@trask trask requested review from heyams and kryalama as code owners January 10, 2022 17:11
heyams
heyams reviewed Jan 10, 2022
View reviewed changes
test/smoke/appServers/global-resources/httpheaders_applicationinsights.json
"instance": "testroleinstance"
},
"preview": {
"captureHttpServerHeaders": {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

not sure how server headers will be helpful for customers? can you share a use case for this?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

is it customer's server or app insights backend server? it's not clear to me.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

customer's app

@trask trask merged commit 8d3603a into main Jan 10, 2022
@trask trask deleted the http-headers branch January 10, 2022 21:05
@zoomingrocket
Copy link

zoomingrocket commented Jan 19, 2022 •
edited
Loading

@trask - How can we use this with 3.2.5-BETA? What should be configured in applicationinsights.json config?
We tried below but does not seem to work

"preview": {
    "instrumentation": {
      "vertx": {
        "enabled": true
      },
      "captureHttpServerHeaders": {
        "enabled": true
      }
}

@trask
Copy link
Member Author

trask commented Jan 20, 2022

hey @zoomingrocket, check out https://docs.microsoft.com/en-us/azure/azure-monitor/app/java-standalone-config#http-headers

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@heyams heyams heyams approved these changes

@kryalama kryalama Awaiting requested review from kryalama

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Log HTTP Headers, Request/Response Body as Custom Request Properties
3 participants
@trask @zoomingrocket @heyams