-
Notifications
You must be signed in to change notification settings - Fork 199
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Don't capture exception records on dependencies #2307
Conversation
2dab327
to
100a510
Compare
@@ -166,6 +167,7 @@ public void map(SpanData span, Consumer<TelemetryItem> consumer) { | |||
consumer.accept(telemetryItem); | |||
exportEvents( | |||
span, | |||
telemetryItem.getData().getBaseData() instanceof RequestData, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
how about !(telemetryItem.getData().getBaseData() instanceof RemoteDependencyData)
?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think it's the same, since we map spans to either requests or dependencies, I think I like instance of RequestData because this is how I am thinking about it after the discussion with Osvaldo:
Application Insights "exceptions" are meant for top-level exceptions (exceptions on request telemetry or logged exceptions)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
does it imply that it can be MessageData too?
// (exceptions on request telemetry or logged exceptions)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
that is in LogDataMapper:
Lines 62 to 67 in e1b89d4
String stack = log.getAttributes().get(SemanticAttributes.EXCEPTION_STACKTRACE); | |
if (stack == null) { | |
consumer.accept(createMessageTelemetryItem(log)); | |
} else { | |
consumer.accept(createExceptionTelemetryItem(log, stack)); | |
} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
(where we create either message or exception record, but not both)
100a510
to
7d68689
Compare
Application Insights "exceptions" are meant for top-level exceptions (exceptions on request telemetry or logged exceptions).