Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

OpenTelemetry Pre-aggregated metrics #2439

Merged
merged 103 commits into from
Aug 26, 2022
Merged

OpenTelemetry Pre-aggregated metrics #2439

merged 103 commits into from
Aug 26, 2022

Conversation

heyams
Copy link
Contributor

@heyams heyams commented Aug 10, 2022

No description provided.

@lgtm-com
Copy link

lgtm-com bot commented Aug 10, 2022

This pull request introduces 1 alert when merging a3b8fdd into 1f6f3b5 - view on LGTM.com

new alerts:

  • 1 for Dereferenced variable may be null

@heyams heyams force-pushed the heya/pre-aggregated-metrics branch from 00c3cd5 to e7849db Compare August 12, 2022 00:17
trask
trask reviewed Aug 24, 2022
View reviewed changes
Copy link
Member

@trask trask left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can you add metric verification to the HttpServer4xx test to verify that we are handling the 4xx configuration setting correctly for metrics?

@heyams
Copy link
Contributor Author

heyams commented Aug 25, 2022 •
edited
Loading

can you add metric verification to the HttpServer4xx test to verify that we are handling the 4xx configuration setting correctly for metrics?

can i leave that to a diff pr?

@heyams heyams closed this Aug 25, 2022
@heyams heyams reopened this Aug 25, 2022
trask
trask reviewed Aug 25, 2022
View reviewed changes
...zure/monitor/opentelemetry/exporter/implementation/preaggregatedmetrics/ExtractorHelper.java Outdated Show resolved Hide resolved
...tests/apps/gRPC/src/smokeTest/java/com/microsoft/applicationinsights/smoketest/GrpcTest.java Outdated Show resolved Hide resolved
...tests/apps/gRPC/src/smokeTest/java/com/microsoft/applicationinsights/smoketest/GrpcTest.java Outdated Show resolved Hide resolved
...Test/java/com/microsoft/applicationinsights/smoketest/HttpPreaggregatedMetricsSmokeTest.java Outdated Show resolved Hide resolved
...Test/java/com/microsoft/applicationinsights/smoketest/HttpPreaggregatedMetricsSmokeTest.java Show resolved Hide resolved
...ure/monitor/opentelemetry/exporter/implementation/preaggregatedmetrics/RequestExtractor.java Outdated Show resolved Hide resolved
.../monitor/opentelemetry/exporter/implementation/preaggregatedmetrics/DependencyExtractor.java Outdated Show resolved Hide resolved
.../monitor/opentelemetry/exporter/implementation/preaggregatedmetrics/DependencyExtractor.java Outdated Show resolved Hide resolved
trask
trask approved these changes Aug 25, 2022
View reviewed changes
Copy link
Member

@trask trask left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🥳

@trask trask merged commit 2170998 into main Aug 26, 2022
@trask trask deleted the heya/pre-aggregated-metrics branch August 26, 2022 02:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jeanbisutti jeanbisutti jeanbisutti left review comments

@trask trask trask approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@heyams @trask @jeanbisutti