Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

GA sampling overrides #3463

Merged
merged 28 commits into from
Feb 26, 2024
Merged

GA sampling overrides #3463

merged 28 commits into from
Feb 26, 2024

Conversation

heyams
Copy link
Contributor

@heyams heyams commented Dec 19, 2023

Fix #3433

@heyams heyams force-pushed the heya/ga-sampling-override branch from b41e03b to 4e0831c Compare February 17, 2024 04:59
trask
trask reviewed Feb 21, 2024
View reviewed changes
Copy link
Member

@trask trask left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can you move the exception related smoke tests over to #3555?

@heyams heyams requested a review from trask February 26, 2024 19:29
trask
trask approved these changes Feb 26, 2024
View reviewed changes
.../main/java/com/microsoft/applicationinsights/agent/internal/diagnostics/etw/EtwAppender.java
@@ -45,7 +45,7 @@ public void start() {
this.etwProvider.writeEvent(event);
} catch (LinkageError | ApplicationInsightsEtwException e) {
String message = "EtwProvider failed to initialize.";
LoggerFactory.getLogger(DiagnosticsHelper.DIAGNOSTICS_LOGGER_NAME).error(message, e);
LoggerFactory.getLogger(DiagnosticsHelper.DIAGNOSTICS_LOGGER_NAME).debug(message, e);
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@heyams heyams merged commit 377bd98 into main Feb 26, 2024
85 checks passed
@heyams heyams deleted the heya/ga-sampling-override branch February 26, 2024 20:18
@timja timja mentioned this pull request Apr 26, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@trask trask trask approved these changes

@jeanbisutti jeanbisutti Awaiting requested review from jeanbisutti jeanbisutti is a code owner

@ramthi ramthi Awaiting requested review from ramthi ramthi is a code owner

Assignees
No one assigned
Labels
3.5.0 GA
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

General Availability target for sampling overrides
2 participants
@heyams @trask