Add smoke test showing OOM due to recursive log capture on Wildfly #3796
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
trask
force-pushed
the
add-oom-test
branch
7 times, most recently
from
add4a68 to
91832ae
Compare
trask
requested review from
heyams,
jeanbisutti,
ramthi and
harsimar
as code owners
heyams
reviewed
Jul 24, 2024
| // System.out back to a logging library which is itself instrumented by the Java agent | ||
| // | ||
| // see OutOfMemoryWithDebugLevelTest for repro that will fail without this code | ||
| CallDepth callDepth = CallDepth.forClass(LoggerProvider.class); |
There was a problem hiding this comment.
is it necessary to use CallDepth here? Log makes sense. BatchItemProcessor is used for span and metrics too.
we passed a copy of BatchItemProcessor into AgentLogExporter.
There was a problem hiding this comment.
this method is run in a different thread (so the thread local doesn't carry over to here)
heyams
approved these changes
Jul 24, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.