Fixes custom telemetry timestamp bug #412
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Do not set telemetry timestamp if it already exists
|
This seems like a small (but important) contribution, so no Contribution License Agreement is required at this point. We will now review your pull request. |
|
@adnanyaqoobvirk , thank you! The provided timestamp should indeed be preserved. Could you please also add a test for this? I think TelemetryClientTests can be a good place for it. |
|
@Dmitry-Matveev, Done. Let me know if you want me to add more tests. |
Dmitry-Matveev
approved these changes
Aug 22, 2017
|
@Dmitry-Matveev consider updating the CHANGELOG.md. I checked other two checkboxes in PR description |
SergeyKanzhelev
approved these changes
Aug 22, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Do not set telemetry timestamp if it already exists
Fixes a bug where track function of TelemetryClient class is overwriting the timestamp that was previously set for the telemetry. This results in not able to specify the order of different events.
For significant contributions please make sure you have completed the following items: