Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change JmxMetricPerformanceCounter #614

Merged
merged 1 commit into from
Mar 22, 2018
Merged

Conversation

brunolins16
Copy link
Member

@brunolins16 brunolins16 commented Mar 20, 2018

This change allow JmxMetricPerformanceCounter to send a new instance of MetricTelemetry instead of reuse it.

Fix #609

For significant contributions please make sure you have completed the following items:

  • CHANGELOG.md updated

@dhaval24
Copy link
Contributor

@brunolins16 have you tested this change locally? Do you see the problem fixed?

@brunolins16
Copy link
Member Author

brunolins16 commented Mar 20, 2018

@dhaval24, sure! The following table is the raw telemetry after the updated jar.

raw_telemetry

@dhaval24
Copy link
Contributor

@brunolins16 thanks a lot for the contribution.

Copy link
Contributor

@littleaj littleaj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome! Thanks for catching this, @brunolins16!

@dhaval24 dhaval24 added this to the 2.0.2 milestone Mar 22, 2018
@dhaval24 dhaval24 added the Bug label Mar 22, 2018
@dhaval24
Copy link
Contributor

@littleaj and @grlima I think this can be merged. Let me know!

@dhaval24 dhaval24 merged commit 74d64b2 into microsoft:master Mar 22, 2018
@maciejkopecpl
Copy link

@dhaval24 how long it will take to have that fix available in maven repo? I'm waiting for it, because I experiencing the same issue :)

@dhaval24
Copy link
Contributor

@MicNeo we expect to release a new version of SDK on Maven shortly. If everything goes smoothly you can expect a release of 2.0.2 version by the end of March to earliest April 1st week.

@brunolins16 brunolins16 deleted the issue-609 branch April 23, 2018 17:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants