Support OTEL_PYTHON_DISABLED_INSTRUMENTATIONS #294
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lzchen
reviewed
Jun 15, 2023
| @@ -10,6 +10,8 @@ | |||
| ([#291](https://github.com/microsoft/ApplicationInsights-Python/pull/291)) | |||
| - Fixing formatting issues for azure sdk | |||
| ([#292](https://github.com/microsoft/ApplicationInsights-Python/pull/292)) | |||
| - Support OTEL_PYTHON_DISABLED_INSTRUMENTATIONS | |||
| ([#XXX](https://github.com/microsoft/ApplicationInsights-Python/pull/XXX)) | |||
There was a problem hiding this comment.
Suggested change
| ([#XXX](https://github.com/microsoft/ApplicationInsights-Python/pull/XXX)) | |
| ([#294](https://github.com/microsoft/ApplicationInsights-Python/pull/294)) |
There was a problem hiding this comment.
lzchen
reviewed
Jun 15, 2023
| # use pkg_resources for now until https://github.com/open-telemetry/opentelemetry-python/pull/3168 is merged | ||
| for entry_point in iter_entry_points( | ||
| "azure_monitor_opentelemetry_instrumentor" | ||
| ): | ||
| lib_name = entry_point.name | ||
| if lib_name not in _SUPPORTED_INSTRUMENTED_LIBRARIES_DEPENDENCIES_MAP: | ||
| continue | ||
| if entry_point.name in disabled_instrumentations: | ||
| _logger.debug( |
There was a problem hiding this comment.
Probably should use _logger.info
There was a problem hiding this comment.
Using debug because it matches the current use in sitecustomize.
lzchen
reviewed
Jun 15, 2023
| @@ -81,6 +86,19 @@ def _default_disable_tracing(configurations): | |||
| configurations[DISABLE_TRACING_ARG] = default | |||
|
|
|||
|
|
|||
| def _default_disabled_instrumentations(configurations): | |||
| disabled_instrumentation = environ.get( | |||
| OTEL_PYTHON_DISABLED_INSTRUMENTATIONS, [] | |||
There was a problem hiding this comment.
Should we add an entry to the README for this configuration?
lzchen
approved these changes
Jun 15, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Using OTEL_PYTHON_DISABLED_INSTRUMENTATIONS functionality from auto instrumentation flow