Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WorkerService project to depend on Microsoft.Extensions.DI 2.1.1 #1794

Merged
merged 1 commit into from
Apr 16, 2020

Conversation

cijothomas
Copy link
Contributor

Fix Issue #1677 .

Changes

(Please provide a brief description of the changes here.)

Checklist

  • I ran Unit Tests locally.
  • CHANGELOG.md updated with one line description of the fix, and a link to the original issue if available.

For significant contributions please make sure you have completed the following items:

  • Design discussion issue #
  • Changes in public surface reviewed

The PR will trigger build, unit tests, and functional tests automatically. Please follow these instructions to build and test locally.

Notes for authors:

  • FxCop and other analyzers will fail the build. To see these errors yourself, compile localy using the Release configuration.

Notes for reviewers:

  • We support comment build triggers
    • /AzurePipelines run will queue all builds
    • /AzurePipelines run <pipeline-name> will queue a specific build

@cijothomas cijothomas merged commit 7e9f17d into develop Apr 16, 2020
@cijothomas cijothomas deleted the cithomas/workerdepversion branch April 16, 2020 17:59
@pramadhav
Copy link

Thanks for working on this. I have a release at work that is breaking the builds which use .NET Core 2.1. Current DI version is 2.1.1. Any idea when the package would be ready and part of which version?

@cijothomas
Copy link
Contributor Author

This will be part of next beta1, due to be released in 1-2 weeks.

@pramadhav
Copy link

Thank you for the update

@pramadhav
Copy link

This will be part of next beta1, due to be released in 1-2 weeks.

Hi, Does 2.14 includes your fix on DI reference to 2.1.1? In the Nuget dependencies, DI dependency is still showing >2.2 for 2.14.0 version

@TimothyMothra
Copy link
Member

Hello, @pramadhav 2.14 does not include this change.
2.14 had some issues that required our attention so the 2.15-beta1 was pushed back another week.

Is this a blocking issue for you? We can have a conversation about expediting the next beta if you'd be willing to validate this change.

@pramadhav
Copy link

Hello, @pramadhav 2.14 does not include this change.
2.14 had some issues that required our attention so the 2.15-beta1 was pushed back another week.

Is this a blocking issue for you? We can have a conversation about expediting the next beta if you'd be willing to validate this change.

hi, Yes, We are really waiting on this fix and anything that you could expedite would greatly help us. I can test my side when the beta is available and update you. In terms of evidence, I cannot provide much as my project is proprietary and confidential to my employer.

@TimothyMothra
Copy link
Member

Hi @pramadhav Sorry for the delay,
We just started the release process for the 2.15-Beta1. It should be available by Friday (5/01)

@TimothyMothra
Copy link
Member

@pramadhav we just released 2.15-Beta1
It should be available on NuGet within the hour ;)
We would love to get your feedback on if this fixes your issue!

@pramadhav
Copy link

sure, will test out in update in the next couple of days

@pramadhav
Copy link

my initial test was successful with DI 2.1.1 dependency. Planning to do more comprehensive test with the Exceptions. Quick question meanwhile
I have wrapped ASPNETCore and WorkerService nuget packages in a C# .NET standard library and using it in our team's .NET Core/ASP.NET core apps. My colleagues want to use it from Java apps too. I would like to explore this, can you please let me know the laetst Java SDK name for App Insights? I appreciate any guidance on that.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants